Limit default allocated processors for the test cluster #133633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to ensure consistent test execution. It also supports clusters before 7.6 where the setting key was `processors` instead of `node .processors`
jozala
added
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
approved these changes
Aug 27, 2025
jozala
commented
Aug 27, 2025
Comment on lines
+1390
to
+1398
| // Limit the number of allocated processors for all nodes in the cluster by default. | ||
| // This is to ensure that the tests run consistently across different environments. | ||
| String processorCount = shouldConfigureTestClustersWithOneProcessor() ? "1" : "2"; | ||
| if (getVersion().onOrAfter("7.6.0")) { | ||
| baseConfig.put("node.processors", processorCount); | ||
| } else { | ||
| baseConfig.put("processors", processorCount); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is moved from InternalTestClustersPlugin.java.
Here we have an access to the version of the node and it seems to be a correct place to set default values.
elasticsearchmachine
added
v8.18.8
v9.1.5
v8.19.5
v9.0.8
and removed
v8.18.7
v9.1.4
v8.19.4
v9.0.7
labels
|
The tests are currently failing because of the |
elasticsearchmachine
added
v8.18.9
v8.19.6
v9.0.9
and removed
v8.18.8
v8.19.5
v9.0.8
labels
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Oct 3, 2025
This is to ensure consistent test execution. It also supports clusters before 7.6 where the setting key was `processors` instead of `node.processors`
This was referenced Oct 3, 2025
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Oct 3, 2025
This is to ensure consistent test execution. It also supports clusters before 7.6 where the setting key was `processors` instead of `node.processors`
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Oct 3, 2025
This is to ensure consistent test execution. It also supports clusters before 7.6 where the setting key was `processors` instead of `node.processors`
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Oct 3, 2025
This is to ensure consistent test execution. It also supports clusters before 7.6 where the setting key was `processors` instead of `node.processors`
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Oct 3, 2025
This is to ensure consistent test execution. It also supports clusters before 7.6 where the setting key was `processors` instead of `node.processors` (cherry picked from commit fa692ab)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 3, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 3, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 3, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 3, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to ensure consistent test execution.
It also supports clusters before 7.6 where the setting key was
processorsinstead ofnode.processors.This is continuation of #133204. That approach failed when running BwC for clusters < 7.6.0.
Related to #130612